feat(build): modify docs navigation hrefs for compatibility with offline documentation #9254
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation browsing
…ing without redirects
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
hydrosquall
force-pushed
the
cameron.yick/experiment-doc-generation-2024
branch
from
36730a7
to
7e01381
Compare
hydrosquall
changed the title
domoritz
reviewed
Feb 4, 2024
site/_data/versions.yml
Outdated
| @@ -0,0 +1,4 @@ | |||
| vega: 5.27.0 | |||
There was a problem hiding this comment.
We generate this at build time so it doesn't need to be in the repo.
There was a problem hiding this comment.
Thanks, would it make sense for me to add this file to the .gitignore?
There was a problem hiding this comment.
Yes but make sure it doesn't cause issues with the page build.
hydrosquall
changed the title
hydrosquall
force-pushed
the
cameron.yick/experiment-doc-generation-2024
branch
from
7e01381
to
5930cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - A modern redo of #7642
Motivation
New Changes
Old Changes
Testing